[GitHub] [carbondata] akkio-97 opened a new pull request #4055: Handled issue with huge data(exceeding 32K records) after enabling local dictionary

classic Classic list List threaded Threaded
23 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4055: [CARBONDATA-4087] Handled issue with huge data(exceeding 32K records) after enabling local dictionary in Presto

GitBox

akkio-97 commented on a change in pull request #4055:
URL: https://github.com/apache/carbondata/pull/4055#discussion_r545003145



##########
File path: core/src/main/java/org/apache/carbondata/core/scan/result/vector/CarbonColumnVector.java
##########
@@ -116,6 +117,13 @@
 
   void setLazyPage(LazyPageLoader lazyPage);
 
+  default int getIntsSize() {
+    return CarbonV3DataFormatConstants.NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT;

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on pull request #4055: [CARBONDATA-4087] Handled issue with huge data(exceeding 32K records) after enabling local dictionary in Presto

GitBox
In reply to this post by GitBox

ajantha-bhat commented on pull request #4055:
URL: https://github.com/apache/carbondata/pull/4055#issuecomment-747376657


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #4055: [CARBONDATA-4087] Handled issue with huge data(exceeding 32K records) after enabling local dictionary in Presto

GitBox
In reply to this post by GitBox

asfgit closed pull request #4055:
URL: https://github.com/apache/carbondata/pull/4055


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


12