[GitHub] [carbondata] dhatchayani commented on a change in pull request #3221: [CARBONDATA-3386] Concurrent Merge index and query is failing

[GitBox]

dhatchayani commented on a change in pull request #3221: [CARBONDATA-3386] Concurrent Merge index and query is failing
URL: https://github.com/apache/carbondata/pull/3221#discussion_r284287775
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CarbonIndexFileMergeTestCase.scala
 ##########
 @@ -300,8 +300,8 @@ class CarbonIndexFileMergeTestCase
     assert(getIndexFileCount("default_nonindexmerge", "1") == 100)
     assert(getIndexFileCount("default_nonindexmerge", "2") == 100)
     assert(getIndexFileCount("default_nonindexmerge", "3") == 100)
-    assert(getIndexFileCount("default_nonindexmerge", "0.1") == 100)
 
 Review comment:
   previously merge index is triggered at the end of load. So validation for valid segments was done. as 0.1 and 2.1 are invalid segments(as they are merged to 0.2), they dont have mergeindex files.
   Current implementation will trigger merge index for all the segments written, in load or compaction case. So 0.1 and 2,1 also have merge index

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services