[GitHub] [carbondata] dhatchayani commented on a change in pull request #3221: [CARBONDATA-3386] Concurrent Merge index and query is failing

[GitBox]

dhatchayani commented on a change in pull request #3221: [CARBONDATA-3386] Concurrent Merge index and query is failing
URL: https://github.com/apache/carbondata/pull/3221#discussion_r284645772
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeIndexEventListener.scala
 ##########
 @@ -67,17 +64,9 @@ class MergeIndexEventListener extends OperationEventListener with Logging {
               carbonTable.getTablePath,
               carbonTable, false)
             // clear Block dataMap Cache
-            clearBlockDataMapCache(carbonTable, Seq(loadModel.getSegmentId))
+            MergeIndexUtil.clearBlockDataMapCache(carbonTable, Seq(loadModel.getSegmentId))
 
 Review comment:
   It is better to have this to avoid unknown impacts. In case of child table creation/load, it will query on the main table load. This is not so costly as the clear is only on the segments not on the whole table.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services