[GitHub] [carbondata] dhatchayani commented on a change in pull request #3485: [CARBONDATA-3596] Fix exception when execute load data command or select sql on a table which includes complex columns after execute 'add column' command

[GitBox]

dhatchayani commented on a change in pull request #3485: [CARBONDATA-3596] Fix exception when execute load data command or select sql on a table which includes complex columns after execute 'add column' command
URL: https://github.com/apache/carbondata/pull/3485#discussion_r351727396
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
 ##########
 @@ -148,8 +148,8 @@ public DictionaryBasedResultCollector(BlockExecutionInfo blockExecutionInfos) {
         // get the complex columns data of this row
         fillComplexColumnDataBufferForThisRow();
         for (int i = 0; i < queryDimensions.length; i++) {
-          fillDimensionData(scannedResult, surrogateResult, noDictionaryKeys, complexTypeKeyArray,
-              comlexDimensionInfoMap, row, i);
+          fillDimensionData(queryDimensions[i], scannedResult, surrogateResult,
 
 Review comment:
   please handle the default values for the restructured blocks in RestructureBasedDictionaryResultCollector.
   For the restructured blocks need to take the default values for the newly added columns.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services