[GitHub] [carbondata] jackylk commented on a change in pull request #2465: [CARBONDATA-2863] Refactored CarbonFile interface

[GitBox]

jackylk commented on a change in pull request #2465: [CARBONDATA-2863] Refactored CarbonFile interface
URL: https://github.com/apache/carbondata/pull/2465#discussion_r349922551
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/S3CarbonFile.java
 ##########
 @@ -60,73 +58,57 @@ object and then performs rename(copy).
           Refer CARBONDATA-2670 for tracking this.
    */
   @Override
-  public boolean renameForce(String changeToName) {
-    FileSystem fs;
+  public boolean renameForce(String changetoName) {
     try {
-      deleteFile(changeToName, FileFactory.getFileType(changeToName));
-      fs = fileStatus.getPath().getFileSystem(hadoopConf);
-      return fs.rename(fileStatus.getPath(), new Path(changeToName));
+      deleteFile();
 
 Review comment:
   This seems wrong, it is deleting the current file before renaming it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services