[GitHub] [carbondata] jackylk commented on a change in pull request #3171: [CARBONDATA-3337] Implemented Hadoop RPC framework for index server

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on a change in pull request #3171: [CARBONDATA-3337] Implemented Hadoop RPC framework for index server

GitBox
jackylk commented on a change in pull request #3171: [CARBONDATA-3337] Implemented Hadoop RPC framework for index server
URL: https://github.com/apache/carbondata/pull/3171#discussion_r277554853
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ##########
 @@ -2104,4 +2104,17 @@ private CarbonCommonConstants() {
    */
   public static final String CARBON_QUERY_DATAMAP_BLOOM_CACHE_SIZE_DEFAULT_VAL = "512";
 
-}
+  public static final String CARBON_INDEX_SERVER_POLICY = "carbon.index.server.policy";
+
+  public static final String CARBON_DISTRIBUTED_PRUNE_POLICY = "distributed";
+
+  public static final String CARBON_EMBEDDED_PRUNE_POLICY = "embedded";
+
+  public static final String CARBON_DRIVER_PRUNE_POLICY = "driver";
+
+  public static final String CARBON_INDEX_SERVER_IP = "carbon.index.server.ip";
 
 Review comment:
   please write comment for all new configuration. Same comment we should put to document

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services