[GitHub] [carbondata] jackylk commented on a change in pull request #3273: [CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null.

[GitBox]

jackylk commented on a change in pull request #3273:
URL: https://github.com/apache/carbondata/pull/3273#discussion_r417793359



##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java
##########
@@ -87,9 +91,13 @@ public boolean hasNext() throws IOException, InterruptedException {
         readers.set(index, null);
         index++;
         currentReader = readers.get(index);
-        return currentReader.nextKeyValue();
+        boolean result = currentReader.nextKeyValue();
+        if (result) {

Review comment:
       ```suggestion
           if (hasNext) {
   ```

##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java
##########
@@ -87,9 +91,13 @@ public boolean hasNext() throws IOException, InterruptedException {
         readers.set(index, null);
         index++;
         currentReader = readers.get(index);
-        return currentReader.nextKeyValue();
+        boolean result = currentReader.nextKeyValue();
+        if (result) {
+          return result;

Review comment:
       ```suggestion
             return true;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]