[GitHub] [carbondata] jackylk commented on a change in pull request #3324: [HOTFIX] Fix task id in FileFormat write

[GitBox]

jackylk commented on a change in pull request #3324: [HOTFIX] Fix task id in FileFormat write
URL: https://github.com/apache/carbondata/pull/3324#discussion_r303194100
 
 

 ##########
 File path: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala
 ##########
 @@ -143,6 +145,13 @@ class SparkCarbonFileFormat extends FileFormat
     conf.set(CarbonSQLHadoopMapReduceCommitProtocol.COMMIT_PROTOCOL, "true")
 
     new OutputWriterFactory {
+
+      /**
+       * counter used for generating unique task numbers.
+       */
+      val counter = new AtomicLong()
 
 Review comment:
   Can we use UUID instead of this shared variable to generate the id? In practise, UUID is better than timestamp

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services