[GitHub] [carbondata] jackylk commented on a change in pull request #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on a change in pull request #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

GitBox
jackylk commented on a change in pull request #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#discussion_r316608881
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala
 ##########
 @@ -135,7 +142,7 @@ private[sql] case class CarbonProjectForUpdateCommand(
           CarbonUpdateUtil.cleanUpDeltaFiles(carbonTable, false)
 
           // do delete operation.
-          val segmentsToBeDeleted = DeleteExecution.deleteDeltaExecution(
+          val (segmentsToBeDeleted, updatedRowCountTemp) = DeleteExecution.deleteDeltaExecution(
 
 Review comment:
   why not assign to updatedRowCount directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services