[GitHub] [carbondata] jackylk commented on a change in pull request #3372: [CARBONDATA-3511] Query time improvement by reducing the number of NameNode calls while having carbonindex files in the store

[GitBox]

jackylk commented on a change in pull request #3372: [CARBONDATA-3511] Query time improvement by reducing the number of NameNode calls while having carbonindex files in the store
URL: https://github.com/apache/carbondata/pull/3372#discussion_r320817104
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
 ##########
 @@ -234,6 +231,10 @@ private BlockletDataMapIndexWrapper get(TableBlockIndexUniqueIdentifierWrapper i
                 tableSegmentUniqueIdentifierWrapper.isAddTableBlockToUnsafeAndLRUCache());
       }
     }
+    String segmentPath =
+        tableSegmentUniqueIdentifierWrapper.getTableBlockIndexUniqueIdentifier().getIndexFilePath();
 
 Review comment:
   `getIndexFilePath()` returns `segmentPath`? It is confusing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services