[GitHub] [carbondata] jackylk commented on a change in pull request #3374: [CARBONDATA-3496] Maintain the list of TableDataMap based on tableId instead of tableName

[GitBox]

jackylk commented on a change in pull request #3374: [CARBONDATA-3496] Maintain the list of TableDataMap based on tableId instead of tableName
URL: https://github.com/apache/carbondata/pull/3374#discussion_r326907055
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
 ##########
 @@ -318,32 +319,32 @@ public TableDataMap getDefaultDataMap(CarbonTable table) {
    * Get the datamap for reading data.
    */
   public TableDataMap getDataMap(CarbonTable table, DataMapSchema dataMapSchema) {
-    String tableUniqueName =
-        table.getAbsoluteTableIdentifier().getCarbonTableIdentifier().getTableUniqueName();
 
 Review comment:
   suggest to remove the `getTableUniqueName` in table identifier thus removing using it in all places

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services