jackylk commented on a change in pull request #3381: [CARBONDATA-3517]Add Segment with Path
URL:
https://github.com/apache/carbondata/pull/3381#discussion_r323776309
##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
##########
@@ -133,8 +133,11 @@
// structure
byte[] filePath = null;
boolean isPartitionTable = blockletDataMapInfo.getCarbonTable().isHivePartitionTable();
- if (isPartitionTable || !blockletDataMapInfo.getCarbonTable().isTransactionalTable()
- || blockletDataMapInfo.getCarbonTable().isSupportFlatFolder()) {
+ if (isPartitionTable || !blockletDataMapInfo.getCarbonTable().isTransactionalTable() ||
+ blockletDataMapInfo.getCarbonTable().isSupportFlatFolder() ||
+ // if the segment data is written in tablepath then no need to store whole path of file.
+ !blockletDataMapInfo.getFilePath().startsWith(
+ blockletDataMapInfo.getCarbonTable().getTablePath())) {
filePath = path.getParent().toString().getBytes(CarbonCommonConstants.DEFAULT_CHARSET);
Review comment:
This has problem in compaction scenario, because this if branch is false thus filePath will be empty. Then query will report NPE after compaction.
Please add a testcase for minor compaction and perform query
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
