jackylk commented on a change in pull request #3381: [CARBONDATA-3517] Add Segment with Path
URL:
https://github.com/apache/carbondata/pull/3381#discussion_r326905902
##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
##########
@@ -133,8 +133,11 @@
// structure
byte[] filePath = null;
boolean isPartitionTable = blockletDataMapInfo.getCarbonTable().isHivePartitionTable();
- if (isPartitionTable || !blockletDataMapInfo.getCarbonTable().isTransactionalTable()
- || blockletDataMapInfo.getCarbonTable().isSupportFlatFolder()) {
+ if (isPartitionTable || !blockletDataMapInfo.getCarbonTable().isTransactionalTable() ||
+ blockletDataMapInfo.getCarbonTable().isSupportFlatFolder() ||
+ // if the segment data is written in tablepath then no need to store whole path of file.
+ !blockletDataMapInfo.getFilePath().startsWith(
+ blockletDataMapInfo.getCarbonTable().getTablePath())) {
filePath = path.getParent().toString().getBytes(CarbonCommonConstants.DEFAULT_CHARSET);
Review comment:
suggest to move this assignment to line 134, filepath = null is dangerous which will lead to NPE while reading in some cases. We have found this in testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
