[GitHub] [carbondata] jackylk commented on a change in pull request #3381: [CARBONDATA-3517] Add Segment with Path

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on a change in pull request #3381: [CARBONDATA-3517] Add Segment with Path

GitBox
jackylk commented on a change in pull request #3381: [CARBONDATA-3517] Add Segment with Path
URL: https://github.com/apache/carbondata/pull/3381#discussion_r326905928
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
 ##########
 @@ -133,8 +133,11 @@
     // structure
     byte[] filePath = null;
 
 Review comment:
   ```suggestion
       byte[] filePath = path.getParent().toString().getBytes(CarbonCommonConstants.DEFAULT_CHARSET);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services