[GitHub] [carbondata] jackylk commented on a change in pull request #3391: [CARBONDATA-3521] optimize read property file code

[GitBox]

jackylk commented on a change in pull request #3391: [CARBONDATA-3521] optimize read property file code
URL: https://github.com/apache/carbondata/pull/3391#discussion_r326907621
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ##########
 @@ -81,7 +81,7 @@ private CarbonCommonConstants() {
    * default carbon properties file path
    */
   public static final String CARBON_PROPERTIES_FILE_PATH_DEFAULT =
-      "../../../conf/carbon.properties";
 
 Review comment:
   I think it is better to keep default value otherwise it will break compatibility when user upgrade to new version

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services