[GitHub] [carbondata] jackylk commented on a change in pull request #3392: [CARBONDATA-3516] Supporting mixed formats in carbon

[GitBox]

jackylk commented on a change in pull request #3392: [CARBONDATA-3516] Supporting mixed formats in carbon
URL: https://github.com/apache/carbondata/pull/3392#discussion_r334905337
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java
 ##########
 @@ -460,4 +460,9 @@ public String getPath() {
   public void setPath(String path) {
     this.path = path;
   }
+
+  public boolean isCarbonSegment() {
 
 Review comment:
   Better to change to `isCarbonFormat`. Since after this PR, CarbonData support mixed format, so all segments are carbon segments, but with different format

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services