[GitHub] [carbondata] jackylk commented on a change in pull request #3415: [CARBONDATA-3553] Support SDK Writer using existing schema file

[GitBox]

jackylk commented on a change in pull request #3415: [CARBONDATA-3553] Support SDK Writer using existing schema file
URL: https://github.com/apache/carbondata/pull/3415#discussion_r336923767
 
 

 ##########
 File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
 ##########
 @@ -493,6 +527,9 @@ public CarbonWriterBuilder withCsvInput(Schema schema) {
    */
   public CarbonWriterBuilder withCsvInput(String jsonSchema) {
     Objects.requireNonNull(jsonSchema, "schema should not be null");
+    if (this.schema == null) {
 
 Review comment:
   Isn't it should be `if (this.schema != null)`, because we need to check the schema is set only once

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services