[GitHub] [carbondata] jackylk commented on a change in pull request #3415: [CARBONDATA-3553] Support SDK Writer using existing schema file

[GitBox]

jackylk commented on a change in pull request #3415: [CARBONDATA-3553] Support SDK Writer using existing schema file
URL: https://github.com/apache/carbondata/pull/3415#discussion_r336924740
 
 

 ##########
 File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
 ##########
 @@ -262,6 +271,18 @@ public CarbonWriterBuilder withLoadOption(String key, String value) {
     return this;
   }
 
+  /**
+   * To support the carbon table for sdk writer
+   *
+   * @param table carbon table
+   * @return CarbonWriterBuilder object
+   */
+  public CarbonWriterBuilder withTable(CarbonTable table) {
 
 Review comment:
   There is a `CarbonWriterBuilder withSchemaFile(String schemaFilePath)` API already, is this `withTable` API required?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services