[GitHub] [carbondata] jackylk commented on a change in pull request #3415: [CARBONDATA-3553] Support SDK Writer using existing schema file

[GitBox]

jackylk commented on a change in pull request #3415: [CARBONDATA-3553] Support SDK Writer using existing schema file
URL: https://github.com/apache/carbondata/pull/3415#discussion_r336950258
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/converter/SchemaConverter.java
 ##########
 @@ -94,16 +94,18 @@ TableSchema fromExternalToWrapperTableSchema(
       org.apache.carbondata.format.TableSchema externalTableSchema, String tableNam);
 
   /**
-   * @param externalTableInfo
-   * @param dbName
-   * @param tableName
-   * @return
+   * method to convert thrift table info object to wrapper table info
+   *
+   * @param externalTableInfo thrift table info object
+   * @param dbName database name
+   * @param tableName table name
+   * @return TableInfo
 
 Review comment:
   tablePath is missing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services