[GitHub] [carbondata] jackylk commented on a change in pull request #3421: [CARBONDATA-3557] Support write Flink streaming data to Carbon

[GitBox]

jackylk commented on a change in pull request #3421: [CARBONDATA-3557] Support write Flink streaming data to Carbon
URL: https://github.com/apache/carbondata/pull/3421#discussion_r339382969
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/statusmanager/FileFormat.java
 ##########
 @@ -46,6 +46,9 @@ public int ordinal() {
   }
 
   public static FileFormat getByOrdinal(int ordinal) {
+    if (ordinal < 0) {
 
 Review comment:
   It should be invalid parameter, suggest to throw exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services