[GitHub] [carbondata] jackylk commented on a change in pull request #3421: [CARBONDATA-3557] Support write Flink streaming data to Carbon

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on a change in pull request #3421: [CARBONDATA-3557] Support write Flink streaming data to Carbon

GitBox
jackylk commented on a change in pull request #3421: [CARBONDATA-3557] Support write Flink streaming data to Carbon
URL: https://github.com/apache/carbondata/pull/3421#discussion_r339383414
 
 

 ##########
 File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
 ##########
 @@ -255,7 +257,7 @@ public synchronized OutputCommitter getOutputCommitter(TaskAttemptContext contex
     }
     if (null == loadModel.getTaskNo() || loadModel.getTaskNo().isEmpty()) {
       loadModel.setTaskNo(taskAttemptContext.getConfiguration()
-          .get("carbon.outputformat.taskno", String.valueOf(System.nanoTime())));
+          .get("carbon.outputformat.taskno", String.valueOf(DEFAULT_TASK_NO.getAndIncrement())));
 
 Review comment:
   Why change to incremental long instead of nanoTime? please add comment in line 123

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services