[GitHub] [carbondata] jackylk commented on a change in pull request #3424: [CARBONDATA-3559] Support adding carbon files into CarbonData table

[GitBox]

jackylk commented on a change in pull request #3424: [CARBONDATA-3559] Support adding carbon files into CarbonData table
URL: https://github.com/apache/carbondata/pull/3424#discussion_r339883061
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
 ##########
 @@ -587,12 +587,13 @@ public static String checkAndAppendDefaultFs(String path, Configuration conf) {
     }
     String defaultFs = conf.get(CarbonCommonConstants.FS_DEFAULT_FS);
     String lowerPath = path.toLowerCase();
-    if (lowerPath.startsWith(CarbonCommonConstants.HDFSURL_PREFIX) || lowerPath
-        .startsWith(CarbonCommonConstants.ALLUXIOURL_PREFIX) || lowerPath
-        .startsWith(CarbonCommonConstants.VIEWFSURL_PREFIX) || lowerPath
-        .startsWith(CarbonCommonConstants.S3N_PREFIX) || lowerPath
-        .startsWith(CarbonCommonConstants.S3A_PREFIX) || lowerPath
-        .startsWith(CarbonCommonConstants.S3_PREFIX)) {
+    if (lowerPath.startsWith(CarbonCommonConstants.HDFSURL_PREFIX) ||
+        lowerPath.startsWith(CarbonCommonConstants.ALLUXIOURL_PREFIX) ||
+        lowerPath.startsWith(CarbonCommonConstants.VIEWFSURL_PREFIX) ||
+        lowerPath.startsWith(CarbonCommonConstants.LOCAL_FILE_PREFIX) ||
 
 Review comment:
   add support for local file path

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services