[GitHub] [carbondata] jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments

[GitBox]

jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
URL: https://github.com/apache/carbondata/pull/3432#discussion_r342944310
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/statusmanager/FileFormat.java
 ##########
 @@ -56,6 +56,13 @@ public static FileFormat getByOrdinal(int ordinal) {
     return COLUMNAR_V3;
   }
 
+  public boolean isCarbonFormat() {
+    if (this.format.equalsIgnoreCase("COLUMNAR_V3") || this.format.equalsIgnoreCase("ROW_V1")) {
 
 Review comment:
   simplify this, change to `return this.format.equalsIgnoreCase("COLUMNAR_V3") | this.format.equalsIgnoreCase("ROW_V1")`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services