[GitHub] [carbondata] jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments

[GitBox]

jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
URL: https://github.com/apache/carbondata/pull/3432#discussion_r344008603
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala
 ##########
 @@ -301,6 +300,8 @@ class AddSegmentTestCase extends QueryTest with BeforeAndAfterAll {
     checkAnswer(sql("select empname from addsegment1 where empname='arvind'"), Seq(Row("arvind"),Row("arvind")))
     checkAnswer(sql("select count(empname) from addsegment1"), Seq(Row(20)))
     checkAnswer(sql("select count(*) from addsegment1"), Seq(Row(20)))
+    val showSeg = sql("show segments for table addsegment1").collectAsList()
+    assert(showSeg.get(0).get(6).toString.equalsIgnoreCase("3.75KB"))
 
 Review comment:
   It is better to get the size from FS instead of hard coded it, this testcase failed in my laptop.
   And please add assert to index size also

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services