[GitHub] [carbondata] jackylk commented on a change in pull request #3483: [CARBONDATA-3597] Support Merge for SCD and CCD scenarios

[GitBox]

jackylk commented on a change in pull request #3483: [CARBONDATA-3597] Support Merge for SCD and CCD scenarios
URL: https://github.com/apache/carbondata/pull/3483#discussion_r360629502
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/block/TableBlockInfo.java
 ##########
 @@ -306,7 +306,7 @@ public boolean equals(Object obj) {
       return  false;
     }
 
-    if (!filePath.equals(other.filePath)) {
+    if (!new Path(filePath).equals(new Path(other.filePath))) {
 
 Review comment:
   Why this is required? please add comment.
   Is there a more efficient way to do it without create new objects

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services