jackylk commented on a change in pull request #3483: [CARBONDATA-3597] Support Merge for SCD and CCD scenarios
URL:
https://github.com/apache/carbondata/pull/3483#discussion_r360630422
##########
File path: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
##########
@@ -211,7 +211,8 @@ public boolean accept(CarbonFile file) {
return file.getName().startsWith(SCHEMA_FILE);
}
});
- if (schemaFile != null && schemaFile.length > 0) {
+ if (schemaFile != null && schemaFile.length > 0 &&
+ FileFactory.getFileType(tablePath) != FileFactory.FileType.ALLUXIO) {
Review comment:
It is a bit strange to handle differently for Alluxio in this class, can we wrap it in different CarbonFile implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services