[GitHub] [carbondata] jackylk commented on a change in pull request #3483: [CARBONDATA-3597] Support Merge for SCD and CCD scenarios

[GitBox]

jackylk commented on a change in pull request #3483: [CARBONDATA-3597] Support Merge for SCD and CCD scenarios
URL: https://github.com/apache/carbondata/pull/3483#discussion_r360630514
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/writer/CarbonIndexFileMergeWriter.java
 ##########
 @@ -173,7 +173,7 @@ private String writeMergeIndexFileBasedOnSegmentFile(String segmentId,
           location =
               segmentFileStore.getTablePath() + CarbonCommonConstants.FILE_SEPARATOR + location;
         }
-        if (new Path(entry.getKey()).equals(new Path(location))) {
+        if (FileFactory.getCarbonFile(entry.getKey()).equals(FileFactory.getCarbonFile(location))) {
 
 Review comment:
   Since this is inside a double for loop, we should avoid creating too many objects. Please describe what is missing in current approach. Is it because `\\` need to be replaced with `/`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services