[GitHub] [carbondata] jackylk commented on a change in pull request #3485: [CARBONDATA-3596] Fix exception when execute load data command or select sql on a table which includes complex columns after execute 'add column' command

[GitBox]

jackylk commented on a change in pull request #3485: [CARBONDATA-3596] Fix exception when execute load data command or select sql on a table which includes complex columns after execute 'add column' command
URL: https://github.com/apache/carbondata/pull/3485#discussion_r353002725
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
 ##########
 @@ -241,7 +241,8 @@ private void fillComplexColumnDataBufferForThisRow() {
 
   void fillDimensionData(BlockletScannedResult scannedResult, int[] surrogateResult,
 
 Review comment:
   please add comment for this method, since it becomes more parameters

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services