[GitHub] [carbondata] jackylk commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

[GitBox]

jackylk commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries
URL: https://github.com/apache/carbondata/pull/3495#discussion_r372783388
 
 

 ##########
 File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/Navigator.scala
 ##########
 @@ -66,7 +79,100 @@ private[mv] class Navigator(catalog: SummaryDatasetCatalog, session: MVSession)
         }
     }
     if (rewrittenPlan.fastEquals(plan)) {
-      None
+      if (modularPlan.asScala.exists(p => p.sameResult(rewrittenPlan))) {
 
 Review comment:
   please extract new function and add comment, this function is too complex

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services