[GitHub] [carbondata] jackylk commented on a change in pull request #3507: [CARBONDATA-3617] loadDataUsingGlobalSort should based on SortColumns…

[GitBox]

jackylk commented on a change in pull request #3507: [CARBONDATA-3617] loadDataUsingGlobalSort should based on SortColumns…
URL: https://github.com/apache/carbondata/pull/3507#discussion_r356966858
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/row/CarbonRow.java
 ##########
 @@ -49,6 +49,14 @@ public CarbonRow(Object[] data, Object[] rawData) {
     return data;
   }
 
+  public Object[] getKey(int[] sortColumnIndex) {
+    Object[] key = new Object[sortColumnIndex.length];
+    for(int i = 0; i < sortColumnIndex.length; i++){
 
 Review comment:
   If you want to copy elements, use `System.arraycopy(data, 0, key, 0, sortColumnIndex.length);` instead of for loop

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services