[GitHub] [carbondata] jackylk commented on a change in pull request #3717: [CARBONDATA-3780]Old store read compatibility issue for Index handler column

[GitBox]

jackylk commented on a change in pull request #3717:
URL: https://github.com/apache/carbondata/pull/3717#discussion_r413543210



##########
File path: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
##########
@@ -605,6 +605,14 @@ public TableSchema fromExternalToWrapperTableSchema(
           .setLocalDictColumnsToWrapperSchema(listOfColumns, externalTableSchema.tableProperties,
               externalTableSchema.tableProperties
                   .get(CarbonCommonConstants.LOCAL_DICTIONARY_ENABLE));
+      String handler = externalTableSchema.tableProperties.get(CarbonCommonConstants.INDEX_HANDLER);
+      if (handler != null) {
+        for (ColumnSchema columnSchema : listOfColumns) {
+          if (handler.equalsIgnoreCase(columnSchema.getColumnName())) {

Review comment:
       @ajantha-bhat I think this feature is still alpha feature in 2.0, 1.6 does not include this feature. For long term benefit, I still think these names should be changed to make it clear to user and developers




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]