[GitHub] [carbondata] jackylk opened a new pull request #3550: [WIP] Remove global dictionary in query

[GitBox]

CarbonDataQA1 commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-575993819
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1691/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-576299200
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1707/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-577106506
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1734/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-577301966
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1741/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-577544269
 
 
   how about thrift file of dictionary?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai edited a comment on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-577544269
 
 
   how about the thrift file of global dictionary?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai edited a comment on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-577544269
 
 
   how about the thrift files of global dictionary?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-577554045
 
 
   @QiangCai Since FileFooter3 uses dictionary.ColumnDictionaryChunk, I will remove it in another PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-577555919
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1755/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-577623641
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1758/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-577827397
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1760/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-578370626
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3550: [CARBONDATA-3605] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services