[GitHub] [carbondata] jackylk opened a new pull request #3597: [CARBONDATA-3575] Remove redundant exception throws

[GitBox]

jackylk commented on a change in pull request #3597: [CARBONDATA-3575] Remove redundant exception throws
URL: https://github.com/apache/carbondata/pull/3597#discussion_r373533053
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/ColumnarSplitter.java
 ##########
 @@ -36,18 +34,16 @@
    *
    * @param keys
    * @return
-   * @throws KeyGenException
    */
-  byte[][] generateAndSplitKey(long[] keys) throws KeyGenException;
+  byte[][] generateAndSplitKey(long[] keys);
 
 Review comment:
   fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3597: [CARBONDATA-3575] Remove redundant exception throws
URL: https://github.com/apache/carbondata/pull/3597#discussion_r373536194
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ImplicitIncludeFilterExecutorImpl.java
 ##########
 @@ -77,7 +73,7 @@ public BitSet isScanRequired(byte[][] blockMaxValue, byte[][] blockMinValue,
   }
 
   @Override
-  public void readColumnChunks(RawBlockletColumnChunks rawBlockletColumnChunks) throws IOException {
+  public void readColumnChunks(RawBlockletColumnChunks rawBlockletColumnChunks) {
 
 Review comment:
   Because some subclass need to throw IOException, so it can't be removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws
URL: https://github.com/apache/carbondata/pull/3597#issuecomment-580778464
 
 
    @xubo245 all redundant throws are removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws
URL: https://github.com/apache/carbondata/pull/3597#issuecomment-580782739
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1820/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws
URL: https://github.com/apache/carbondata/pull/3597#issuecomment-580796222
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1822/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws
URL: https://github.com/apache/carbondata/pull/3597#issuecomment-580875172
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1823/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

xubo245 commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws
URL: https://github.com/apache/carbondata/pull/3597#issuecomment-581113783
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3597: [CARBONDATA-3575] Remove redundant exception throws
URL: https://github.com/apache/carbondata/pull/3597
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services