[GitHub] [carbondata] jackylk opened a new pull request #3613: [HOTFIX] Remove unused parameter in TabelModel

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk opened a new pull request #3613: [HOTFIX] Remove unused parameter in TabelModel

GitBox
jackylk opened a new pull request #3613: [HOTFIX] Remove unused parameter in TabelModel
URL: https://github.com/apache/carbondata/pull/3613
 
 
    ### Why is this PR needed?
    parentTable and parentTableRelation are not used in the TableModel, they can be removed
   
    ### What changes were proposed in this PR?
    parentTable and parentTableRelation are removed in TableModel
       
    ### Does this PR introduce any user interface change?
    - No
   
   
    ### Is any new testcase added?
    - No
   
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3613: [HOTFIX] Remove unused parameter in TabelModel

GitBox
CarbonDataQA1 commented on issue #3613: [HOTFIX] Remove unused parameter in TabelModel
URL: https://github.com/apache/carbondata/pull/3613#issuecomment-585099798
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/251/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3613: [HOTFIX] Remove unused parameter in TabelModel

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3613: [HOTFIX] Remove unused parameter in TabelModel
URL: https://github.com/apache/carbondata/pull/3613#issuecomment-585123341
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1954/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai commented on issue #3613: [HOTFIX] Remove unused parameter in TabelModel

GitBox
In reply to this post by GitBox
QiangCai commented on issue #3613: [HOTFIX] Remove unused parameter in TabelModel
URL: https://github.com/apache/carbondata/pull/3613#issuecomment-585224758
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3613: [HOTFIX] Remove unused parameter in TabelModel

GitBox
In reply to this post by GitBox
asfgit closed pull request #3613: [HOTFIX] Remove unused parameter in TabelModel
URL: https://github.com/apache/carbondata/pull/3613
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services