[GitHub] [carbondata] jackylk opened a new pull request #3638: [WIP] Avoid data copy in Writer

classic Classic list List threaded Threaded
43 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk opened a new pull request #3638: [WIP] Avoid data copy in Writer

GitBox
jackylk opened a new pull request #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638
 
 
    ### Why is this PR needed?
    Currently there are 6 data copies during data write process, in CarbonFactDataHandlerColumnar.processDataRows
   
    ### What changes were proposed in this PR?
   This PR avoid all data copy by using DirectByteBuffer
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590251490
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/428/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590251925
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2128/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590338695
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/435/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590339219
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2135/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590389915
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/437/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590390665
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2137/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590406286
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2138/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590412292
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/438/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590786470
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2162/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590788006
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/461/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590791016
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2164/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-590797805
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/463/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-591226481
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/477/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-591237646
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2176/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-591347412
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/497/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-591370329
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2196/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-592916688
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/538/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [WIP] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-592918540
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2239/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#issuecomment-593814117
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/572/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
123