[GitHub] [carbondata] jackylk opened a new pull request #3657: [CARBONDATA-3736] Improve show segment

classic Classic list List threaded Threaded
70 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3657: [CARBONDATA-3736] Support show segment by query

GitBox
ajantha-bhat commented on a change in pull request #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657#discussion_r405398278
 
 

 ##########
 File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonShowSegmentsByQueryCommand.scala
 ##########
 @@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.management
 
 Review comment:
   please update new syntax supported in
   `segment-management-on-carbondata.md`
   
   also mention the columns available for the user to use it in the select query of the show segment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on issue #3657: [CARBONDATA-3736] Support show segment by query

GitBox
In reply to this post by GitBox
kunal642 commented on issue #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657#issuecomment-610872293
 
 
   LGTM, @jackylk Please rebase

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3657: [CARBONDATA-3736] Support show segment by query

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657#issuecomment-612090510
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/997/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3657: [CARBONDATA-3736] Support show segment by query

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657#issuecomment-612094052
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2709/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on issue #3657: [CARBONDATA-3736] Support show segment by query

GitBox
In reply to this post by GitBox
jackylk commented on issue #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657#issuecomment-612382636
 
 
   Doc is added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on issue #3657: [CARBONDATA-3736] Support show segment by query

GitBox
In reply to this post by GitBox
jackylk commented on issue #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657#issuecomment-612382644
 
 
   Doc is added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3657: [CARBONDATA-3736] Support show segment by query

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657#issuecomment-612409599
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1001/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on issue #3657: [CARBONDATA-3736] Support show segment by query

GitBox
In reply to this post by GitBox
ajantha-bhat commented on issue #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657#issuecomment-612409841
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3657: [CARBONDATA-3736] Support show segment by query

GitBox
In reply to this post by GitBox
asfgit closed pull request #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3657: [CARBONDATA-3736] Support show segment by query

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3657: [CARBONDATA-3736] Support show segment by query
URL: https://github.com/apache/carbondata/pull/3657#issuecomment-612410319
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2713/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
1234