kevinjmh commented on a change in pull request #3278: [CARBONDATA-3427] Beautify DAG by showing less text
URL:
https://github.com/apache/carbondata/pull/3278#discussion_r292872228
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDatasourceHadoopRelation.scala
##########
@@ -195,8 +195,7 @@ case class CarbonDatasourceHadoopRelation(
override def unhandledFilters(filters: Array[Filter]): Array[Filter] = new Array[Filter](0)
override def toString: String = {
- "CarbonDatasourceHadoopRelation [ " + "Database name :" + identifier.getDatabaseName +
- ", " + "Table name :" + identifier.getTableName + ", Schema :" + tableSchema + " ]"
+ "carbondata"
Review comment:
OK. The reason I set it as "carbondata" because I test parquet table, it get the source shortName to print, "parquet". Actually `CarbonSource` also defines a shortName, but it used different logic.
It's fine for me if you all have strong will to change the name to identify where this text from.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
