[GitHub] [carbondata] kevinjmh commented on a change in pull request #3321: [HOTFIX] Reset the hive catalog table stats to none even after refresh lookup relation.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kevinjmh commented on a change in pull request #3321: [HOTFIX] Reset the hive catalog table stats to none even after refresh lookup relation.

GitBox
kevinjmh commented on a change in pull request #3321: [HOTFIX] Reset the hive catalog table stats to none even after refresh lookup relation.
URL: https://github.com/apache/carbondata/pull/3321#discussion_r301855593
 
 

 ##########
 File path: integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonInMemorySessionState.scala
 ##########
 @@ -154,14 +156,22 @@ class InMemorySessionCatalog(
   }
 
   override def lookupRelation(name: TableIdentifier): LogicalPlan = {
-    val rtnRelation = super.lookupRelation(name)
+    var rtnRelation = super.lookupRelation(name)
     val isRelationRefreshed =
-      CarbonSessionUtil.refreshRelation(rtnRelation, name)(sparkSession)
+      CarbonSessionUtil.refreshRelationAndSetStats(rtnRelation, name)(sparkSession)
     if (isRelationRefreshed) {
-      super.lookupRelation(name)
-    } else {
-      rtnRelation
+      rtnRelation = super.lookupRelation(name)
 
 Review comment:
   what is the meaning of line 159-163? (Is it possible change to  refresh->lookupRelation?)
   thx
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services