[GitHub] [carbondata] kevinjmh commented on a change in pull request #3400: Fix query on bloom in case of multiple data files in one segment

[GitBox]

kevinjmh commented on a change in pull request #3400: Fix query on bloom in case of multiple data files in one segment
URL: https://github.com/apache/carbondata/pull/3400#discussion_r348878739
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java
 ##########
 @@ -152,11 +152,14 @@ public static DataMapJob getEmbeddedJob() {
   /**
    * Prune the segments from the already pruned blocklets.
    */
-  public static void pruneSegments(List<Segment> segments, List<ExtendedBlocklet> prunedBlocklets) {
+  public static void pruneSegments(List<Segment> segments, List<ExtendedBlocklet> prunedBlocklets,
+      boolean clearExistingShards) {
     Set<Segment> validSegments = new HashSet<>();
     for (ExtendedBlocklet blocklet : prunedBlocklets) {
       // Clear the old pruned index files if any present
-      blocklet.getSegment().getFilteredIndexShardNames().clear();
 
 Review comment:
   @shivamasn  FYI:  wrong query result is occurred for hive partition table+bloom because this line of code too. Remove this line or apply this pr makes that fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services