[GitHub] [carbondata] kevinjmh commented on a change in pull request #3422: [CARBONDATA-3558] Clean up codes for property "autoRefreshDataMap"

[GitBox]

kevinjmh commented on a change in pull request #3422: [CARBONDATA-3558] Clean up codes for property "autoRefreshDataMap"
URL: https://github.com/apache/carbondata/pull/3422#discussion_r340981686
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapProvider.java
 ##########
 @@ -120,7 +120,7 @@ public void initData() { }
   /**
    * Rebuild the datamap by loading all existing data from mainTable
    * This is called when refreshing the datamap when
-   * 1. after datamap creation and if `autoRefreshDataMap` is set to true
+   * 1. after datamap creation and no "WITH DEFERRED REBUILD" defined
 
 Review comment:
   The document does not mention `autoRefreshDataMap` now. As for the section title `Automatic Refresh`, it is explained  with `WITH DEFERRED REBUILD` in its parent section `DataMap Management`.
   
   
   https://github.com/apache/carbondata/blob/2db8bf234b4234a9cbf3245ac39ed7391a84f77e/docs/datamap/datamap-management.md#L56-L64

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services