kevinjmh commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter
URL:
https://github.com/apache/carbondata/pull/3444#discussion_r349420428
##########
File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
##########
@@ -217,6 +220,14 @@ public BitSet prunePages(RawBlockletColumnChunks rawBlockletColumnChunks)
bitSet.set(i);
}
}
Review comment:
I know that, as written in the description of this PR. However, applyFilter and prunePages is quite similar, I am wondering if anyone can refactor this part first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
