[GitHub] [carbondata] kevinjmh opened a new pull request #3604: [HOTFIX] Allow space between input file paths

[GitBox]

kevinjmh opened a new pull request #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604
 
 
    ### Why is this PR needed?
    When space exists between file paths, `The input file does not exist` is throw.
   
   ```
   LOAD DATA INPATH 'hdfs:///data/file1.dat , hdfs:///data/file2.dat' INTO TABLE ...
   ```
   
    ### What changes were proposed in this PR?
   trim space of each file path before usage
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#issuecomment-582297612
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/155/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#issuecomment-582318408
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1858/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Indhumathi27 commented on a change in pull request #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#discussion_r375247744
 
 

 ##########
 File path: integration/spark-common/src/main/scala/org/apache/spark/util/FileUtils.scala
 ##########
 @@ -73,7 +73,7 @@ object FileUtils {
       throw new DataLoadingException("Input file path cannot be empty.")
     } else {
       val stringBuild = new StringBuilder()
-      val filePaths = inputPath.split(",")
+      val filePaths = inputPath.split(",").map(_.trim)
 
 Review comment:
   Can you please add a testcase for this scenario

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kevinjmh commented on a change in pull request #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#discussion_r377428236
 
 

 ##########
 File path: integration/spark-common/src/main/scala/org/apache/spark/util/FileUtils.scala
 ##########
 @@ -73,7 +73,7 @@ object FileUtils {
       throw new DataLoadingException("Input file path cannot be empty.")
     } else {
       val stringBuild = new StringBuilder()
-      val filePaths = inputPath.split(",")
+      val filePaths = inputPath.split(",").map(_.trim)
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#issuecomment-584463207
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/224/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#issuecomment-584472350
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1926/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kevinjmh commented on issue #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#issuecomment-584490290
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#issuecomment-584494923
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/226/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#issuecomment-584506061
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1928/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on issue #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604#issuecomment-585021757
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3604: [HOTFIX] Allow space between input file paths
URL: https://github.com/apache/carbondata/pull/3604
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services