[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3177: [CARBONDATA-3337][CARBONDATA-3306] Distributed index server

[GitBox]

kumarvishal09 commented on a change in pull request #3177: [CARBONDATA-3337][CARBONDATA-3306] Distributed index server
URL: https://github.com/apache/carbondata/pull/3177#discussion_r280711554
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapFactory.java
 ##########
 @@ -140,6 +142,11 @@ public abstract DataMapBuilder createBuilder(Segment segment, String shardName,
    */
   public abstract void deleteDatamapData();
 
+  /**
+   * delete datamap data if any
+   */
+  public abstract void deleteSegmentDatamapData(String segmentNo) throws IOException;
 
 Review comment:
   Can u add default implementation here so all the child classes which ever want their specific implementation can override, currently all the child class implementing this method without any logic  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services