kumarvishal09 commented on a change in pull request #3188: [CARBONDATA-3358] Support configurable decode for loading binary data, support base64 and Hex decode.
URL:
https://github.com/apache/carbondata/pull/3188#discussion_r288080520
##########
File path: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java
##########
@@ -426,6 +432,24 @@ private void validateAndSetColumnCompressor(CarbonLoadModel carbonLoadModel)
}
}
+
+ private void validateAndSetBinaryDecoder(CarbonLoadModel carbonLoadModel)
+ throws InvalidLoadOptionException {
+ try {
+ String binaryDecoder = carbonLoadModel.getBinaryDecoder();
+ if (StringUtils.isBlank(binaryDecoder)) {
+ binaryDecoder = CarbonProperties.getInstance().getProperty(
+ CarbonLoadOptionConstants.CARBON_OPTIONS_BINARY_DECODER,
+ CarbonLoadOptionConstants.CARBON_OPTIONS_BINARY_DECODER_DEFAULT);
+ }
+ // check and load binary decoder
+ carbonLoadModel.setBinaryDecoder(binaryDecoder);
+ } catch (Exception e) {
Review comment:
Please remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
