kumarvishal09 commented on a change in pull request #3189: [CARBONDATA-3359]Fix data mismatch issue for decimal column after delete operation
URL:
https://github.com/apache/carbondata/pull/3189#discussion_r279702686
##########
File path: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java
##########
@@ -261,18 +266,22 @@ void fillVector(Object valuesToBeConverted, int size, ColumnVectorInfo info, Bit
return new BigDecimal(bigInteger, scale);
}
- @Override public void fillVector(Object valuesToBeConverted, int size, ColumnVectorInfo info,
- BitSet nullBitset, DataType pageType) {
- CarbonColumnVector vector = info.vector;
- int precision = info.measure.getMeasure().getPrecision();
- int newMeasureScale = info.measure.getMeasure().getScale();
+ @Override public void fillVector(Object valuesToBeConverted, int size,
+ ColumnVectorInfo vectorInfo, BitSet nullBitSet, DataType pageType) {
+ CarbonColumnVector vector = vectorInfo.vector;
Review comment:
Can you refactor this code, move to some method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
