[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3194: [CARBONDATA-3363] SDK supports read carbon data by given file lists, file or folder

[GitBox]

kumarvishal09 commented on a change in pull request #3194: [CARBONDATA-3363] SDK supports read carbon data by given file lists, file or folder
URL: https://github.com/apache/carbondata/pull/3194#discussion_r285632314
 
 

 ##########
 File path: store/sdk/src/test/java/org/apache/carbondata/sdk/file/ImageTest.java
 ##########
 @@ -815,4 +817,153 @@ public void binaryToCarbonWithHWD(String sourceImageFolder, String outputPath, S
     reader.close();
   }
 
+  @Test
+  public void testBinaryWithProjectionAndFileListsAndWithFile() throws Exception {
+    int num = 3;
 
 Review comment:
   why this much big test case ?
   have a folder with multiple carbondata files having one or two column. Read it with file, filelist, folder.
   
   No need of image, decode logic and all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services