[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3247: [CARBONDATA-3405] Fix getSplits() should clear the cache in SDK

[GitBox]

kumarvishal09 commented on a change in pull request #3247: [CARBONDATA-3405] Fix getSplits() should clear the cache in SDK
URL: https://github.com/apache/carbondata/pull/3247#discussion_r289261502
 
 

 ##########
 File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
 ##########
 @@ -409,6 +406,9 @@ private CarbonFileInputFormat prepareFileInputFormat(Job job, boolean enableBloc
     CarbonFileInputFormat format = prepareFileInputFormat(job, enableBlockletDistribution, false);
     List<InputSplit> splits =
         format.getSplits(new JobContextImpl(job.getConfiguration(), new JobID()));
+    // Clear the datamap cache as it is added in getSplits() method
 
 Review comment:
   Can u add try finally here so In case of any exception it will clear the data map , pls check

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services