[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3277: [CARBONDATA-3440] Updated alter table DDL to accept upgrade_segments as a compaction type.

[GitBox]

kumarvishal09 commented on a change in pull request #3277: [CARBONDATA-3440] Updated alter table DDL to accept upgrade_segments as a compaction type.
URL: https://github.com/apache/carbondata/pull/3277#discussion_r299320576
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/hadoop/CarbonInputSplit.java
 ##########
 @@ -439,8 +434,19 @@ public Segment getSegment() {
       out.writeShort(blockletId);
     }
     out.writeBoolean(isLegacyStore);
+    writeDeleteDeltaFile(out);
+  }
+
+  private void writeDeleteDeltaFile(DataOutput out) throws IOException {
 
 Review comment:
   In case of index server ...index executor will not write delete delta information, so we need to add a check if it's a index server case do not write delete delta file, otherwise reading will not work

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services