[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3419: [CARBONDATA-3555] Make move filter related methods under DataMapFilter

[GitBox]

kumarvishal09 commented on a change in pull request #3419: [CARBONDATA-3555] Make move filter related methods under DataMapFilter
URL: https://github.com/apache/carbondata/pull/3419#discussion_r346731306
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapFilter.java
 ##########
 @@ -72,6 +85,17 @@ public Expression getNewCopyOfExpression() {
     }
   }
 
+  public DataMapFilter(SegmentProperties properties, CarbonTable table, Expression expression) {
 
 Review comment:
   Move this constructor above getNewCopyOfExpression method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services