[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3419: [CARBONDATA-3555] Make move filter related methods under DataMapFilter

[GitBox]

kumarvishal09 commented on a change in pull request #3419: [CARBONDATA-3555] Make move filter related methods under DataMapFilter
URL: https://github.com/apache/carbondata/pull/3419#discussion_r346733469
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapFilter.java
 ##########
 @@ -115,10 +139,12 @@ public DataMapFilter(FilterResolverIntf resolver) {
     this.resolver = resolver;
   }
 
-  private void resolve() {
+  public void resolve(boolean lazyResolve) {
     if (expression != null) {
-      table.processFilterExpression(expression, null, null);
-      resolver = CarbonTable.resolveFilter(expression, table.getAbsoluteTableIdentifier());
+      processFilterExpression();
+      if (!lazyResolve) {
 
 Review comment:
   please add comment when lazyResolve will be true and false

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services